Backend: cache events and contributor listings #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| site.corecontributors = contributors('bitcoin/bitcoin',site.config['aliases']) | ||
| site.sitecontributors = contributors('bitcoin-dot-org/bitcoin.org',site.config['aliases']) | ||
| ## Create cache directory if it doesn't exist | ||
| system 'mkdir', '-p', '_cache' |
There was a problem hiding this comment.
@harding How about the ruby equivalent Dir.mkdir('_cache') if !File.exists?('_cache')
(This line of code also occurs elsewhere)
|
That solution is also elegant in that it prevents repeated API calls by default when testing! And probably improve performances quite a bit at the same time. Thanks, LGTM |
|
@saivann amended commit to use the Ruby mkdir (didn't know about that, thanks!). Thanks for reviewing! In the absence of critical feedback, this will be merged on Wednesday. |
harding
added a commit
to harding/bitcoin.org
that referenced
this pull request
Sep 9, 2015
- 1048: Conditionally build some pages differently based on environmental variables - 1051: Backend: cache events and contributor listings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making changes to the site, Saïvann and I often diff the resulting HTML output with output from earlier known-good commits. One problem with this method is that the HTML output isn't fully deterministic---some of it comes from external sites and can change massively between two builds that are only minutes apart, making reading the diff unpleasant and less useful than it could be.
This commit caches that external data between builds so that two builds on the same computer are very nearly deterministic. As evidence, at the end of this message I offer inline the full diff of two sequential builds both on this commit.
Cached Meetup.com events, Bitcoin Core contributor listings, and Bitcoin.org contributor listings are retained for 24 hours before being refreshed. Cached Geo-location data for conferences is retained until the _events.yml file is updated. Caches are updated based on file timestamps, so they can be manipulated using
touchor simply deleted to fetch new data.This commit includes one small miscellaneous change to the Makefile to reduce the size of the /commit.txt file. (The replaced command didn't work the way I thought it did; this command produces the correct output.)