Deterministic Payment Event Follow Ups #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 8, 2025
f3r10
approved these changes
Aug 11, 2025
f3r10
approved these changes
Aug 11, 2025
f3r10
approved these changes
Aug 11, 2025
f3r10
approved these changes
Aug 11, 2025
f3r10
approved these changes
Aug 11, 2025
f3r10
approved these changes
Aug 11, 2025
f3r10
approved these changes
Aug 11, 2025
f3r10
approved these changes
Aug 11, 2025
f3r10
approved these changes
Aug 11, 2025
f3r10
approved these changes
Aug 11, 2025
f3r10
approved these changes
Aug 11, 2025
Then the Sender<SimulationOutput> is dropped by setup_payemnt_events, the corresponding Receiver<SimulationOutput> will send None once all of the events have been drained from it. If we listen on shutdown triggers, we don't have the opportunity to drain this channel and complete reporting all of our payments. Remove listening on the listener, as we can just rely on canonical channel mechanics.
Absolute is already apparent from the use of SystemTime, rename to indicate what this is used for. simln-lib/refactor: rename absolute_time to execution_time Absolute is already apparent from the use of SystemTime, rename to indicate what this is used for.
We already have to look up our payment executor in generate_payment, so here we remove unnecessary additional parameter telling us a value we'll be looking up anyway.
Also shorten some log lines while we're here.
Rather than need to downcast the dyn LightningNode, we store the raw mock in our test builder output and add a helper to cast to dyn.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #277.
This PR contains some follow ups for this PR, primarily style fixes and refactors.