-
Notifications
You must be signed in to change notification settings - Fork 39
Closed
Labels
Medium PriorityfeatureNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Milestone
Description
rust-lightning just merged a way to build Features<T> from a BE byte vector.
Update the dependency when the release becomes available (possibly in ~2/3 months, given they just released) so we can update our CLN feature parsing:
- https://github.com/bitcoin-dev-project/sim-ln/blob/main/sim-lib/src/cln.rs#L252-L256
- https://github.com/bitcoin-dev-project/sim-ln/blob/main/sim-lib/src/cln.rs#L92 (I just realized this one is wrong, we should also be reversing byte vector, but we never faced the issue given CLN is not returning any Dependency Bug: CLN GetInfo returns None Features #85 :/ )
carlaKC
Metadata
Metadata
Assignees
Labels
Medium PriorityfeatureNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers