Skip to content

merged pr's number of comments only seems to count independent comments #14

Open

Description

@Extheoisah

In the merged PRs section, the indicated number of comments only seems to count independent comments, not line comments on the diff.
Feedback: There's still uncertainty of whether a batch review should count as one comment total or one comment per line, or whether replies to line comments should count as comments, but I'd lean towards giving everything 1 point---the goal for me today was to see whether the person was making impactful changes (typically indicated by high participation from others) versus typo-fix-level contributions.

Activity

  1. moved this from 🆕 Todo to 📋 Backlog in The Bitcoin Development Project Roadmapon Apr 11, 2024
  2. moved this from 📋 Backlog to 🆕 Todo in The Bitcoin Development Project Roadmapon May 6, 2024
  3. igbopharaoh commented on May 9, 2024

    @igbopharaoh
    Collaborator

    I investigated this issue and we switched the way we are getting the comment count from the comments array which accounted for independent comments to totalCommentsCount which accounts for all comments related to the pr.

    Can you test to see if this issue still persists ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions