Content fixes and improvements for transactions module

[deadmanoz]

Hey @jrakibi took a bit longer than I originally planned for. I've worked through the Transactions module and found a few minor fixes and have proposed some improved language in some parts.

First up let me just say that this content is very good and needed very little revision! It's engaging, well illustrated and has interesting references to historical transcactions and history (I learnt a bit!). It's at the right level for what it aims to be, is appropriately broken down and should allow people to put it down and pick it up next time around. Much respect!

BOSS specific, it aligns well with the earlier course material, especially the signet wallet challenge. I imagine if peoeple have access to this material from the outset of tackling that challenge, we'd see people progressing through at a faster rate and with a clearer understanding. And the more people that understand this, the better the Bitcoin ecosystem will be in the long run.

Anyway here's the specific feedback. Some screenshots of my local testing of some changes:

Here are some screenshots of the incorrectly indented code samples or text samples that I've fixed:

In the early pages, e.g. Input Count, you introduce a new TX in the "Hexidecimal format" Graphic, wheres you've got a different TX at the top of the page in the interactive TX (https://mempool.space/tx/89699cce128a694b4fb3be0e07ae0a9b63f0da1bc62fb3a4eb3c5a497fbae881). Was initially a bit confused as to why there are 2 totally seperate TXs.

Switching between the terms Compact Size and varInt in the Input Count section without being explicit may be confusing for newbies. It's only later clarified on the Compact Size page.

In Step 5: Calculate Preimage and Sighash, I think you need to mention something about the value of locktime being set to a value as specified in the BIP test vector, and mention that more often than not it would have a different value (e.g. 0x00000000)

Fee-calculation. Using the terms block reward and block subsidy interchangeable. I've corrected the text in my PR as per the below definition, but you need to update this image accordingly and re-check:

• The Block Subsidy is the new bitcoins
• The Block Reward is the sum of the Block Subsidy & Transaction fees
  

Also under Fee Calculation, the following topics don't have pages (even placeholders) yet, but there are a few others that do have even just placeholder pages.

• 4. Fee Bumping
• 5. Security Budget Problems

The text on all of the images on the Creating a Transaction page is a little bit hard to read. It doesn't look so bad now and nothing appears to have changed 🤷‍♀️ but it was looking pretty bad for me a few days ago:

Also on this page some of the expand and collapsing sections, e.g. What are UTXOs? and Why is Change needed? feel unnecessary as the volume of hidden text is tiny:

[jrakibi]

These are really great suggestions
Mad, thanks for your contribution.

I left one comment regarding external links, but apart from that, everything looks good.
Hope to see you doing more decoding-bitcoin patches

[jrakibi]

can we make this an external link so it opens in a new tab? In general, we open external links outside Decoding in a new tab

[deadmanoz]

No worries, will do!

[jrakibi]

Also, I'll update the images accordingly with these new changes.

The text on all of the images on the 'Creating a Transaction' page is a little bit hard to read. It doesn't look so bad now, and nothing appears to have changed 🤷‍♀️, but it looked pretty bad to me a few days ago:

I pushed a fix for this a few days ago, which is why it looks better now. However, I still think it's a bit hard to read, especially on small devices, so I'll fix that

[jrakibi]

LGTM
thanks @deadmanoz for your contribution 👑

[jrakibi]

Merged