-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x-only ECDH without sqrt #262
Open
peterdettman
wants to merge
14
commits into
bitcoin-core:master
Choose a base branch
from
peterdettman:ecdh-mult-xo
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jun 29, 2015
-
- Add zero/one sanity check tests for ecmult - Add unit test for secp256k1_scalar_split_lambda_var - Typo fix in `ge_equals_ge`; was comparing b->y to itself, should have been comparing a->y to b->y - Normalize y-coordinate in `random_group_element_test`; this is needed to pass random group elements as the first argument to `ge_equals_ge`, which I will do in a future commit.
Configuration menu - View commit details
-
Copy full SHA for a828df5 - Browse repository at this point
Copy the full SHA a828df5View commit details
Commits on Jun 30, 2015
-
Add constant-time
secp256k1_point_multiply
for ECDHDesigned with clear separation of the wNAF conversion, precomputation and exponentiation (since the precomp at least we will probably want to separate in the API for users who reuse points a lot. Future work: - actually separate precomp in the API - do multiexp rather than single exponentiation
Configuration menu - View commit details
-
Copy full SHA for 955774c - Browse repository at this point
Copy the full SHA 955774cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1bcca35 - Browse repository at this point
Copy the full SHA 1bcca35View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b43041 - Browse repository at this point
Copy the full SHA 6b43041View commit details -
Make
secp256k1_scalar_add_bit
conditional; make `secp256k1_scalar_s……plit_lambda_var` constant time This has the effect of making `secp256k1_scalar_mul_shift_var` constant time in both input scalars. Keep the _var name because it is NOT constant time in the shift amount. As used in `secp256k1_scalar_split_lambda_var`, the shift is always the constant 272, so this function becomes constant time, and it loses the `_var` suffix.
Configuration menu - View commit details
-
Copy full SHA for 59c5720 - Browse repository at this point
Copy the full SHA 59c5720View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48dc8e3 - Browse repository at this point
Copy the full SHA 48dc8e3View commit details
Commits on Jul 2, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 171470e - Browse repository at this point
Copy the full SHA 171470eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c641e06 - Browse repository at this point
Copy the full SHA c641e06View commit details -
Make
secp256k1_scalar_add_bit
conditional; make `secp256k1_scalar_s……plit_lambda_var` constant time This has the effect of making `secp256k1_scalar_mul_shift_var` constant time in both input scalars. Keep the _var name because it is NOT constant time in the shift amount. As used in `secp256k1_scalar_split_lambda_var`, the shift is always the constant 272, so this function becomes constant time, and it loses the `_var` suffix.
Configuration menu - View commit details
-
Copy full SHA for a35d91b - Browse repository at this point
Copy the full SHA a35d91bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0436dfc - Browse repository at this point
Copy the full SHA 0436dfcView commit details
Commits on Jul 3, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 67d307c - Browse repository at this point
Copy the full SHA 67d307cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a5914a - Browse repository at this point
Copy the full SHA 2a5914aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d23d8c5 - Browse repository at this point
Copy the full SHA d23d8c5View commit details
Commits on Jul 4, 2015
-
Configuration menu - View commit details
-
Copy full SHA for a5eaa21 - Browse repository at this point
Copy the full SHA a5eaa21View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.