Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add missing fe comparison checks for inverse field test cases #1489

Merged
merged 2 commits into from
Feb 27, 2024
Merged

tests: add missing fe comparison checks for inverse field test cases #1489

merged 2 commits into from
Feb 27, 2024

Commits on Jan 31, 2024

  1. tests: add missing fe comparison checks for inverse field test cases 

    `check_fe_equal` is a wrapper around `secp256k1_fe_equal` that takes
care of normalization. Since it doesn't check anything itself, the
CHECK macro is needed at the call-sites to actually ensure equality.
    @theStack
    theStack committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    00111c9 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. refactor: rename check_fe_equal -> fe_equal 

    As this function doesn't do any checking, it's better to rename it,
so that it's less likely to miss the needed `CHECK`.
    @theStack
    theStack committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    e7bdddd View commit details
    Browse the repository at this point in the history