Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schnorrsig API improvements #1089

Merged
merged 5 commits into from
Mar 24, 2022
Merged

Schnorrsig API improvements #1089

merged 5 commits into from
Mar 24, 2022

Commits on Mar 17, 2022

  1. Add SECP256K1_DEPRECATED attribute for marking API parts as deprecated

    @real-or-random
    real-or-random committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    3db0560 View commit details
    Browse the repository at this point in the history

  2. Use SECP256K1_DEPRECATED for existing deprecated API functions

    @real-or-random
    real-or-random committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    fc94a2d View commit details
    Browse the repository at this point in the history

  3. schnorrsig: Rename schnorrsig_sign to schnorsig_sign32 and deprecate

    @real-or-random
    real-or-random committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    99e6568 View commit details
    Browse the repository at this point in the history

  4. schnorrsig: Adapt example to new API

    @real-or-random
    real-or-random committed Mar 17, 2022
    1 Configuration menu
    Copy the full SHA
    f813bb0 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2022

  1. docs: Fix return value for functions that don't have invalid inputs 

    _tagged_sha256 simply cannot have invalid inputs.

The other functions could in some sense have invalid inputs but only in
violation of the type system. For example, a pubkey could be invalid but
invalid objects of type secp256k1_pubkey either can't be obtained
via the API or will be caught by an ARG_CHECK when calling pubkey_load.

This is consistent with similar functions in the public API, e.g.,
_ec_pubkey_negate or _ec_pubkey_serialize.
    @real-or-random
    real-or-random committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    b8f8b99 View commit details
    Browse the repository at this point in the history