PR feedback: add more wycheproof ECDH test cases

Co-authored-by: Sean Andersen <6730974+andozw@users.noreply.github.com>
bitcoin-core · Oct 17, 2024 · 4ccf267 · 4ccf267
1 parent f26c323
commit 4ccf267
Show file tree

Hide file tree

Showing 3 changed files with 583 additions and 490 deletions.
diff --git a/src/modules/ecdh/tests_impl.h b/src/modules/ecdh/tests_impl.h
@@ -170,8 +170,7 @@ static void test_ecdh_wycheproof(void) {
 
         expected_result = testvectors[t].expected_result;
 
-        /* fail if public key is valid, but doesn't parse */
-        CHECK(parsed_ok || expected_result == 0);
+        CHECK(parsed_ok == expected_result);
 
         if (!parsed_ok && expected_result == 0) {
             continue;