Merge #28: snap: Remove gpg check at build time

faa58b7 snap: Remove gpg check at build time (MarcoFalke)

Pull request description:

  The check passes locally and remotely on travis. E.g. https://travis-ci.org/MarcoFalke/packaging/builds/569334266#L3287

  However, the key import no longer works on the launchpad architecture for some unknown reason.
  See https://code.launchpad.net/~bitcoin-core/+snap/bitcoin-core-snap-master:

  * https://code.launchpad.net/~bitcoin-core/+snap/bitcoin-core-snap-master/+build/640145/+files/buildlog_snap_ubuntu_xenial_arm64_bitcoin-core-snap-master_BUILDING.txt.gz
  * https://code.launchpad.net/~bitcoin-core/+snap/bitcoin-core-snap-master/+build/640144/+files/buildlog_snap_ubuntu_xenial_armhf_bitcoin-core-snap-master_BUILDING.txt.gz
  * https://code.launchpad.net/~bitcoin-core/+snap/bitcoin-core-snap-master/+build/640143/+files/buildlog_snap_ubuntu_xenial_amd64_bitcoin-core-snap-master_BUILDING.txt.gz
  * https://code.launchpad.net/~bitcoin-core/+snap/bitcoin-core-snap-master/+build/640130/+files/buildlog_snap_ubuntu_xenial_arm64_bitcoin-core-snap-master_BUILDING.txt.gz
  * https://code.launchpad.net/~bitcoin-core/+snap/bitcoin-core-snap-master/+build/640129/+files/buildlog_snap_ubuntu_xenial_armhf_bitcoin-core-snap-master_BUILDING.txt.gz
  * https://code.launchpad.net/~bitcoin-core/+snap/bitcoin-core-snap-master/+build/640128/+files/buildlog_snap_ubuntu_xenial_amd64_bitcoin-core-snap-master_BUILDING.txt.gz

  Fix the build error, which is hard to debug remotely and not reproducible locally, by removing the gpg check. This should be fine, as we trust the Ubuntu launchpad architecture anyway to build and deliver the correct package to users.

  The shasum check is still in place to protect against obvious errors and advanced users are encouraged to and might be able to verify the shasum themselves.

Top commit has no ACKs.

Tree-SHA512: 7b216c595b71f726e16077e76e930451c75500f739449338bb2a00b46cd0e46b0c489b1bb4ab5d4c1389eb0e868b8005c51084b900cee557b5d89ad56401c863

snap/snapcraft.yaml

@@ -42,8 +42,6 @@ parts:
       wget https://bitcoincore.org/bin/bitcoin-core-${SNAPCRAFT_PROJECT_VERSION}/SHA256SUMS.asc
       wget https://bitcoincore.org/bin/bitcoin-core-${SNAPCRAFT_PROJECT_VERSION}/bitcoin-${SNAPCRAFT_PROJECT_VERSION}.tar.gz
       wget https://bitcoincore.org/bin/bitcoin-core-${SNAPCRAFT_PROJECT_VERSION}/bitcoin-${SNAPCRAFT_PROJECT_VERSION}-${SNAPCRAFT_ARCH_TRIPLET}.tar.gz
-      gpg --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys 01EA5486DE18A882D4C2684590C8019E36C2E964
-      gpg --verify SHA256SUMS.asc
       echo "311ed802bbd06b4997c40f62e171b08ec471a2182de9eafed3e3d3382f028c34  SHA256SUMS.asc" | sha256sum --check
       sha256sum --ignore-missing --check SHA256SUMS.asc
       tar -xvf bitcoin-${SNAPCRAFT_PROJECT_VERSION}-${SNAPCRAFT_ARCH_TRIPLET}.tar.gz