Skip to content

Fix CMake minimum required version #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanofsky merged 1 commit into from
Aug 29, 2022
Merged

Fix CMake minimum required version #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Distributed under the MIT software license, see the accompanying
# file COPYING or http://www.opensource.org/licenses/mit-license.php.

cmake_minimum_required(VERSION 3.0)
cmake_minimum_required(VERSION 3.8)
Copy link
Member Author

@hebasto hebasto Aug 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering https://repology.org/project/cmake/versions, maybe 3.10 is also justified?

Copy link
Collaborator

@ryanofsky ryanofsky Aug 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering https://repology.org/project/cmake/versions, maybe 3.10 is also justified?

I'm not actually sure what specifically here requires 3.10, but would welcome any followup PR that changes the minimum version or adds a comment explaining the current minimum.

Copy link
Member Author

@hebasto hebasto Aug 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not actually sure what specifically here requires 3.10

Nothing requires 3.10. Just thinking about availability of CMake 3.8 and 3.9 on real systems.

project("Libmultiprocess" CXX)
include(CMakePushCheckState)
include(CheckCXXSourceCompiles)
Expand Down