Add simpler ServeStream function#14
Merged
ryanofsky merged 1 commit intobitcoin-core:masterfrom Sep 13, 2019
Merged
Conversation
Be more consistent with ConnectStream and just require Init message type instead of ProxyServer constructing callback, and file descriptor number instead of a stream object.
ryanofsky
added a commit
that referenced
this pull request
Sep 13, 2019
710238c Add simpler ServeStream function (Russell Yanofsky) Pull request description: Be more consistent with ConnectStream and just require Init message type instead of ProxyServer constructing callback, and file descriptor number instead of a stream object. Top commit has no ACKs. Tree-SHA512: afb7c755cf8c1977b5e6a1ea0f87df4790f307cfe128c6236da7579eb4ac585bbcbddeb0d83a08ea9fa6ed09d8b92b14612eed73f99afd071e1211633abfc855
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be more consistent with ConnectStream and just require Init message type
instead of ProxyServer constructing callback, and file descriptor number
instead of a stream object.