Replace ProxyServer connection pointer with reference#11
Merged
ryanofsky merged 1 commit intobitcoin-core:masterfrom Aug 19, 2019
Merged
Replace ProxyServer connection pointer with reference#11ryanofsky merged 1 commit intobitcoin-core:masterfrom
ryanofsky merged 1 commit intobitcoin-core:masterfrom
Conversation
This is just cleanup. Using a pointer instead of reference used to be necessary before the Connection constructor took a make_server option. But now there is no reason to have a pointer and unnecessary null handling. Also, Connection add_client option and AddClient RemoveClient ServeStream wrapper functions are removed. These were originally meant to simplify usages but cause more trouble than they are worth.
ryanofsky
added a commit
that referenced
this pull request
Aug 19, 2019
e7687db Replace ProxyServer connection pointer with reference (Russell Yanofsky) Pull request description: This is just cleanup. Using a pointer instead of reference used to be necessary before the Connection constructor took a make_server option. But now there is no reason to have a pointer and unnecessary null handling. Also, Connection add_client option and AddClient RemoveClient ServeStream wrapper functions are removed. These were originally meant to simplify usages but cause more trouble than they are worth. Top commit has no ACKs. Tree-SHA512: a566d5b7b228a412c6bb9184f24e72a288719ea6f28bdc39bbbfe2c05436fa7f9ef8301988781374db765be846e2a5ad38de73e118115b4bce5dfabc2efc3f9e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just cleanup. Using a pointer instead of reference used to be necessary
before the Connection constructor took a make_server option. But now there is
no reason to have a pointer and unnecessary null handling.
Also, Connection add_client option and AddClient RemoveClient ServeStream
wrapper functions are removed. These were originally meant to simplify usages
but cause more trouble than they are worth.