Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v27.0 attestations for all and noncodesigned #1193

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

davidgumberg
Copy link
Contributor

No description provided.

@achow101
Copy link
Member

achow101 commented Apr 17, 2024

The key you've added does not appear to be the one that you signed with:

$ gpg --list-keys davidgumberg
pub   ed25519 2024-04-17 [SC]
      8BFD59DA7618E1710FA27AA688FA1A28D7821B26
uid           [ unknown] davidgumberg <davidzgumberg@gmail.com>
sub   cv25519 2024-04-17 [E]

$ gpg --verify 27.0/davidgumberg/noncodesigned.SHA256SUMS.asc
gpg: assuming signed data in '27.0/davidgumberg/noncodesigned.SHA256SUMS'
gpg: Signature made Tue 16 Apr 2024 09:45:31 PM EDT
gpg:                using EDDSA key 41E442A14C342C877AE4DC8F3B6305FA06DE51D5
gpg: Can't check signature: No public key

@davidgumberg davidgumberg force-pushed the 27.0-davidgumberg-codesigned branch from c9f4775 to 647d2c1 Compare April 17, 2024 02:55
@davidgumberg
Copy link
Contributor Author

Thanks for catching that, I got a bit confused about the cli flags for overriding the signing name in contrib/guix/guix-attest

The key should be correct now.

@achow101 achow101 merged commit 338d191 into bitcoin-core:main Apr 17, 2024
1 check passed
Copy link

@RanaAli996 RanaAli996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants