-
Notifications
You must be signed in to change notification settings - Fork 326
Intro: Never change the prune checkbox after the user has touched it #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intro: Never change the prune checkbox after the user has touched it #658
Conversation
hernanmarino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cr ACK 76cb089 and tested ACK
pablomartin4btc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Title and description mismatch of the PR confuse me, I tested bitcoin-qt before and after the change and I don't see the difference in the behaviour (from the UI point of view, haven't checked the proper prunning).
I've ticked & unticked the prune checkbox and set a value, verifying the value is persisted in the config. Also combined the previous starting qt with -prune param set to 0, 1 and 600.
Perhaps I've some config that bypass this change? Could you please clarify? Sorry if I miss anything too obvius here.
Looks like a bug in the master branch, as it should be like that: |
|
@ryanofsky Could you be interesting in reviewing of this PR? |
|
Closing due to a long period of inactivity here. Feel free to reopen. |
|
Reopening by request |
76cb089 to
051b049
Compare
|
Rebased |
051b049 to
bee0ffb
Compare
hebasto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK bee0ffb, both commits are improvements of the current behaviour. Tested on Ubuntu 23.10.
Re-PR from bitcoin/bitcoin#18729
Now includes a bugfix too (
-prune=2+disabled the checkbox, but-prune=0/1did not; this behaviour is necessary since-pruneoverrides GUI settings)