Add translator comments to TransactionDesc::FormatTxStatus

[w0xlt]

This PR adds translator comments to TransactionDesc::FormatTxStatus as suggested in #552 (comment) and #552 (comment).

[laanwj]

Concept ACK, but I think this belongs in the GUI repo. It also does more than add translator comments, which should be in the PR description.

[hebasto]

Concept ACK, but I think this belongs in the GUI repo.

It does :)

It also does more than add translator comments, which should be in the PR description.

This PR is based on top of the #552. Should be rebased after merging the latter. Only the last commit belongs to this PR.

[laanwj]

It does :)

Huh. Yes, it is. Sorry.

[hebasto]

@w0xlt

#552 has just been merged. Want to rebase this one?

And please finish every translator comment with a full stop character .

[w0xlt]

Rebased. Thanks.

[shaavan]

ACK 767304e

The added translator's comments are clean and concise and clearly represent the meaning of the sentences they intend to explain.

[hebasto]

To avoid unnecessary string split, which makes translation much harder, I'd suggest before applying translation comments to refactor a bit:

--- a/src/qt/transactiondesc.cpp
+++ b/src/qt/transactiondesc.cpp
@@ -38,8 +38,16 @@ QString TransactionDesc::FormatTxStatus(const interfaces::WalletTxStatus& status
     if (depth < 0) {
         return tr("conflicted with a transaction with %1 confirmations").arg(-depth);
     } else if (depth == 0) {
-        const QString abandoned{status.is_abandoned ? QLatin1String(", ") + tr("abandoned") : QString()};
-        return tr("0/unconfirmed, %1").arg(inMempool ? tr("in memory pool") : tr("not in memory pool")) + abandoned;
+        QString s;
+        if (inMempool) {
+            s = tr("0/unconfirmed, in memory pool");
+        } else {
+            s = tr("0/unconfirmed, not in memory pool");
+        }
+        if (status.is_abandoned) {
+            s += QLatin1String(", ") + tr("abandoned");
+        }
+        return s;
     } else if (depth < 6) {
         return tr("%1/unconfirmed").arg(depth);
     } else {

[w0xlt]

@hebasto thanks for suggestion. Done.

[katesalazar]

Concept ACK

[jarolrod]

Concept ACK

[hebasto]

@w0xlt This looks ready to be merged with or without addressing #583 (comment)

What is your opinion?

[w0xlt]

@hebasto I addressed #583 (comment) . Thanks.

[hebasto]

ACK 8cfb562

[jonatack]

ACK, thanks for updating.