Skip to content

English translations update #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2021
Merged

English translations update #323

merged 2 commits into from
May 17, 2021

Conversation

laanwj
Copy link
Member

@laanwj laanwj commented May 10, 2021

Update for Transifex. Needed after bitcoin/bitcoin#21836.

@hebasto
Copy link
Member

hebasto commented May 11, 2021

@laanwj

If this PR will be updated, could you rebase it to include the recent changes from #296?

@laanwj laanwj force-pushed the 2021-05-translations-update branch from 99e9808 to c34a49f Compare May 17, 2021 11:47
@laanwj
Copy link
Member Author

laanwj commented May 17, 2021

Updated.

(I only just noticed I made this branch to the gui repository itself instead of my fork. Sorry for that. Will take care to delete it after merge.)

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c34a49f, verified that make -C src translate returns zero updated strings (as all of them are updated in the top commit):

...
Updating 'qt/locale/bitcoin_en.ts'...
    Found 1048 source text(s) (0 new and 1048 already existing)
...

@hebasto hebasto changed the title qt: English translations update English translations update May 17, 2021
@hebasto hebasto merged commit 6d1d33d into master May 17, 2021
@laanwj laanwj deleted the 2021-05-translations-update branch May 17, 2021 13:19
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request May 17, 2021
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants