Display fRelayTxes and bip152_highbandwidth_{to, from} in peer details #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatack
force-pushed
the
add-fields-to-peer-details
branch
from
e91bcb5 to
caf9b87
Compare
|
I think this is ready for review 🚀 Will add last block and last transaction fields in a separate pull to keep this change small.
|
8 tasks
jarolrod
reviewed
Feb 17, 2021
There was a problem hiding this comment.
Concept ACK, just a few thoughts
The usage of text symbols to indicate something makes sense in a CLI environment, as used in the netinfo dashboard:
In adding these new fields, I don't think we should continue to use the same text symbols used in a CLI environment in a GUI environment.
Suggestions:
Relay Transactions
- I don't think it's great UX to show a checkmark when the peer is relaying transactions and nothing when it isn't. It would be better to have a simple
TRUEorFALSEfor each case. - The tooltip should also be modified to have bullet points just like the high-bandwidth field's tooltip has
High Bandwidth
- The
.and*symbols are small. I think aTOandFROMkey-word would be a better fit, given the context of the GUI environment, and provide a better UX experience.
When Not Applicable
- Currently, if any of these fields are not applicable they will still show up and show up empty. Perhaps we can fill in the space with
N/Aor not show the field at all. Below is a screenshot showing this behavior.
maflcko
reviewed
Feb 18, 2021
jonatack
force-pushed
the
add-fields-to-peer-details
branch
from
caf9b87 to
142807a
Compare
|
Thanks @jarolrod and @MarcoFalke. Updated to "Wants Tx Relay" (Yes/No) and "High Bandwidth" (To/From/No). Updated the tooltips accordingly. |
|
review ACK 142807a |
|
Good points @Talkless, will retouch those in the next patch adding last block and last transaction fields. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 22, 2021
…… …th_{to, from} in peer details
maflcko
pushed a commit
that referenced
this pull request
Mar 7, 2021
…provements 6242bee Hoist repeated translated strings to RPCConsole struct members (Jon Atack) 0f035c1 RPCConsole::updateDetailWidget: convert strings to translated strings (Jon Atack) Pull request description: - fixups from #206 review feedback (thanks!), see commit message for details - hoists repeatedly used translatable strings to the `RPCConsole` class for reuse ACKs for top commit: hebasto: re-ACK 6242bee Talkless: tACK 6242bee, tested on Debian Sid with Qt 5.15.2. I see "Ban for.." translated to my native language as before, "To/From/Yes/No" are not but that's expected, as `.ts` files are not updated. jarolrod: ACK 6242bee Tree-SHA512: 20a296511c5ac03a816766237fa2731b0360dedebf1bea02711eb21d7e4eae2a63a051fe48f4726052edc3e6318952f01fef920cd4b22a8196c39c23d8e5cc3a
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Feb 3, 2022
Summary: > gui: display fRelayTxes in peer details > gui: display BIP152 high bandwidth relay in peer details This is a backport of [[bitcoin-core/gui#206 | core-gui#206]] Depends on D10962 Test Plan: `ninja && src/qt/bitcoin-qt` In the Peers view, select a peer and check the new "high bandwidth" and "Wants Tx Relay" fields. Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10963
gwillen
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Jun 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull adds two fields to the peer details, "Wants Tx Relay" (fRelayTxes) and "High Bandwidth" (bip152_highbandwidth to/from). See the added tooltips for more info.