Remove BDB checkbox in wallet creation dialog

[maflcko]

Please describe the feature you'd like to see added.

With BDB being removed soon, it seems confusing and harmful to allow users to create fresh BDB wallets going forward, as it would load them with an additional burden of having to migrate them soon after.

Is your feature related to a problem, if so please describe it.

No response

Describe the solution you'd like

Remove BDB checkbox

Describe any alternatives you've considered

No response

Please leave any additional context

Power users can still create BDB wallets in the meantime, if they really want to, with an older release, or in the RPC console.

[hebasto]

Concept ACK.

[hebasto]

cc @achow101 @Sjors

[furszy]

Could also only show the check box when the deprecatedrpc=create_bdb (bitcoin/bitcoin#28597) is enabled.

[maflcko]

Could also only show the check box when the deprecatedrpc=create_bdb (bitcoin/bitcoin#28597) is enabled.

Sure, no objection. Though, if someone is enough of an expert to set the setting, they can also figure out how to use the RPC?

[hebasto]

@furszy

Want to submit a PR?

[Sjors]

Concept ACK

I also think people should use the RPC if the really want a legacy wallet.

(and I suspect we can drop a little bit of code complexity because fewer combinations of checkboxes are possible)