Description
Moved from: bitcoin/bitcoin#17969
What Happens
When you click File|Sign Message, the UI asks you to choose an address with which to sign. You can enter one by hand, paste from clipboard, or "Choose a previously used address." The third option provides a list of addresses that includes addresses for which there is no private key (P2SH addresses). This is intimately related to #10542 but the fix here is straightforward.
Expected Behavior
I expect addresses for which no private key is known to be excluded from the list presented. I realize that the same list is used to select an address to which to receive a payment, but that code could be adjusted to accept a filter, or the private-key-less addresses could be filtered out during display.
To reproduce
Ensure that you have at least one P2SH address in your Bitcoin core wallet.
Select File | Sign Message
Click the address book.
Note that there are P2SH addresses offered for selection.
This is in Bitcoin Core 0.18.