Text not visible for `hide` button on macOS

[brunoerg]

On the modal, it is not possible to read the button text. I think the text color is the same of the background one making it unreadable. I tested it on Windows 10 and seems ok.

MacOS 11.1 - compiled from 0.21 (./autogen.sh && ./configure && make -j "$(($(sysctl -n hw.physicalcpu)+1))")

[jarolrod]

what system (OS Version, Qt version). Is this compiled? Built through depends? Please provide more information

[hebasto]

@brunoerg

Has Bitcoin Core window a focus?

[brunoerg]

@hebasto yes!

[brunoerg]

I forgot that, sorry! Updated. @jarolrod

[jarolrod]

@brunoerg the window does not have focus in your screenshot as the exit buttons in the top left are not colorized. If you click on the bitcoin-qt window again, does the color show back up on the button?

[brunoerg]

@brunoerg In the screenshot is not, but I tested it with focus. Same thing here.

[brunoerg]

I'll disable dark mode to test it.

[brunoerg]

@jarolrod

Screen.Recording.2021-04-28.at.12.43.35.mov

[jarolrod]

@brunoerg that recording shows a bug with theme switching that would be fixed by #275

[brunoerg]

@jarolrod Thanks, I will test that! But I am not sure if the concept is the same.

[hebasto]

@jarolrod

@brunoerg that recording shows a bug with theme switching that would be fixed by #275

Not for now.

It'd better to replace this UI-element with something better...

[hebasto]

The "Hide" button is a part of the ModalOverlay widget which is customized with style sheets. In cases of conflicts with other customization (e.g., macOS style plugin), style sheets could take precedence.

To avoid such conflicts, I see the following options:

• replace the "Hide" button with a QLabel "Press ESC to bla-bla...", and listen to the "press ESC" event
• rework ModalOverlay widget to avoid style sheets using
• drop ModalOverlay widget altogether