-
Notifications
You must be signed in to change notification settings - Fork 50
Add OptionButton control #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
cd5527f
qml: Use window color instead of background
promag 6bedd3d
qml: Remove explicit height of BlockCounter
promag 5b00612
qml: Drop import qualifier BitcoinCoreComponents
promag 37cfe4e
qml: Use ColumnLayout in application window
promag cbe91f6
qml: Add OptionButton control
promag 7985aad
qml: Add ConnectionOptions component
promag 61668e9
qml: Show ConnectionOptions
promag File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
// Copyright (c) 2021 The Bitcoin Core developers | ||
// Distributed under the MIT software license, see the accompanying | ||
// file COPYING or http://www.opensource.org/licenses/mit-license.php. | ||
|
||
import QtQuick 2.12 | ||
import QtQuick.Controls 2.12 | ||
import QtQuick.Layouts 1.11 | ||
import "../controls" | ||
|
||
ColumnLayout { | ||
ButtonGroup { | ||
id: group | ||
} | ||
spacing: 15 | ||
OptionButton { | ||
ButtonGroup.group: group | ||
Layout.fillWidth: true | ||
text: qsTr("Fast always on") | ||
description: qsTr("Loads quickly at all times and uses as much cellular data as needed.") | ||
recommended: true | ||
} | ||
OptionButton { | ||
ButtonGroup.group: group | ||
Layout.fillWidth: true | ||
checked: true | ||
text: qsTr("Slow always on") | ||
description: qsTr("Loads quickly at all times and uses as much cellular data as needed.") | ||
} | ||
OptionButton { | ||
ButtonGroup.group: group | ||
Layout.fillWidth: true | ||
text: qsTr("Only when on Wi-Fi") | ||
description: qsTr("Loads quickly when on wi-fi and pauses when on cellular data.") | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
// Copyright (c) 2021 The Bitcoin Core developers | ||
// Distributed under the MIT software license, see the accompanying | ||
// file COPYING or http://www.opensource.org/licenses/mit-license.php. | ||
|
||
import QtQuick 2.12 | ||
import QtQuick.Controls 2.12 | ||
import QtQuick.Layouts 1.11 | ||
|
||
Button { | ||
property string description | ||
property bool recommended: false | ||
id: button | ||
padding: 15 | ||
checkable: true | ||
background: Rectangle { | ||
border.width: 1 | ||
border.color: button.checked ? "#F7931A" : button.hovered ? "white" : "#999999" | ||
radius: 10 | ||
color: "transparent" | ||
Rectangle { | ||
visible: button.visualFocus | ||
anchors.fill: parent | ||
anchors.margins: -4 | ||
border.width: 2 | ||
border.color: "#F7931A" | ||
radius: 14 | ||
color: "transparent" | ||
opacity: 0.4 | ||
} | ||
} | ||
contentItem: ColumnLayout { | ||
spacing: 3 | ||
Label { | ||
Layout.fillWidth: true | ||
Layout.preferredWidth: 0 | ||
font.family: "Inter" | ||
font.styleName: "Regular" | ||
font.pointSize: 18 | ||
color: "white" | ||
text: button.text | ||
wrapMode: Text.WordWrap | ||
} | ||
Label { | ||
Layout.fillWidth: true | ||
Layout.preferredWidth: 0 | ||
font.family: "Inter" | ||
font.styleName: "Regular" | ||
font.pixelSize: 15 | ||
color: "#DEDEDE" | ||
text: button.description | ||
wrapMode: Text.WordWrap | ||
} | ||
Loader { | ||
Layout.topMargin: 2 | ||
active: button.recommended | ||
visible: active | ||
sourceComponent: Label { | ||
background: Rectangle { | ||
color: "white" | ||
radius: 3 | ||
} | ||
font.styleName: "Regular" | ||
font.pixelSize: 13 | ||
topPadding: 3 | ||
rightPadding: 7 | ||
bottomPadding: 4 | ||
leftPadding: 7 | ||
color: "black" | ||
text: qsTr("Recommended") | ||
} | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any plan on how to set the

minimumHeight
to correspond to the required minimum size of the contents?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should set these once we settle down the main/window layout.