Discard QtQuickControls1Plugin since it is not used #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
I agree. But now we are using it in the |
|
Looks like this other plugins depend on this one, need to investigate. |
hebasto
added a commit
that referenced
this pull request
Nov 3, 2021
7dc95a0 doc: Drop unneeded runtime dependencies (Hennadii Stepanov) 48fb724 Revert "build, qml: Add qtquickcontrols module" (Hennadii Stepanov) 4734e5a qml: Replace QtQuick.Dialogs with QtQuick.Controls 2 Dialog (Hennadii Stepanov) Pull request description: On the main branch (da6ae1c) the QtQuick.Controls 1 are required only in the `initerrormessage.qml`, which is certainly unimportant for the UX. This PR suggests a new implementation of the `initerrormessage.qml` without dependencies on QtQuick.Controls 1. Closes #39. An alternative to #63. [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/Win64%20\[unit%20tests,%20no%20gui%20tests,%20no%20boost::process,%20no%20functional%20tests\]%20\[focal\]/insecure_win_gui.zip?branch=pull/77) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macOS%2010.15%20\[gui,%20no%20tests\]%20\[focal\]/insecure_mac_gui.zip?branch=pull/77) ACKs for top commit: promag: Tested ACK 7dc95a0. Built depends aarch64-apple-darwin20.3.0 and checked that app loads and works as expected. Tree-SHA512: 6dc572f81d489f74310a335009d51f7c9fea778bcb7c3ba364fffab391176fa55f188fbce5888502faae47087e5620c0e72bceb9319cbe06bf9cc6c68a28fcc5
](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/Win64%20\[unit%20tests,%20no%20gui%20tests,%20no%20boost::process,%20no%20functional%20tests\]%20\[focal\]/insecure_win_gui.zip?branch=pull/77){kind=link}
](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macOS%2010.15%20\[gui,%20no%20tests\]%20\[focal\]/insecure_mac_gui.zip?branch=pull/77){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we want to use/mix QtQuick controls version 1 and version 2.