Add regular and semibold typefaces of Inter font #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK. To reduce risk of conflicts during syncing with the main repo I'd refrain from the first commit. We could add it later, after merging this repo into the main one. |
|
@hebasto good point, I'll remove it and maybe propose the prefix in main repo 1st. Edit: actually the 1st and 2nd commits can be proposed 1st. |
hebasto
added a commit
to bitcoin-core/gui
that referenced
this pull request
Oct 9, 2021
d54ec27 qt: Add helper to load font (João Barbosa) Pull request description: Originally submitted as bitcoin-core/gui-qml#49. ACKs for top commit: hebasto: re-ACK d54ec27 stratospher: Tested ACK d54ec27. Refactoring the code and defining `loadFont()` in `src/qt/guiutil.cpp` reduces redundant imports of the `QFontDatabase` and is a better design. shaavan: ACK d54ec27 Tree-SHA512: b156bb6ffb08dd57476f383a29bbb0a1108b62794d430debb77252f7d09df1409a7532b09d17d8836d1c2ab7c126a6618231164b9d0def1b8f361a81ef22d107
Merged
promag
force-pushed
the
2021-10-inter-font
branch
from
a5c1200 to
26de8b0
Compare
Merged
hebasto
added a commit
that referenced
this pull request
Oct 19, 2021
Pull request description: Sync with the main repo up to bitcoin-core/gui@ef59692. This sync includes: - bitcoin/bitcoin#23242 ported from #49 - bitcoin/bitcoin#23286 ported from #58 Parent commits: ``` $ git rev-parse 8967f19^@ 8cfb3cb ef59692 ``` ACKs for top commit: jarolrod: ACK 8967f19 Tree-SHA512: c387e638862afe5fd4711d9c1aad36165d04f328612c9b74b35a50b477933e6c6b8cf0674caf3b02e24a22d8598aee7e880baf4c3879c629f71a92af31714548
|
One more rebase? |
promag
force-pushed
the
2021-10-inter-font
branch
from
26de8b0 to
5071af5
Compare
promag
force-pushed
the
2021-10-inter-font
branch
from
5071af5 to
b36cf20
Compare
|
@hebasto rebased. |
promag
force-pushed
the
2021-10-inter-font
branch
from
b36cf20 to
3751fd8
Compare
promag
force-pushed
the
2021-10-inter-font
branch
from
3751fd8 to
b36cf20
Compare
hebasto
approved these changes
Oct 22, 2021
There was a problem hiding this comment.
ACK b36cf20, tested on Linux Mint 20.2 (Qt 5.12.8):
Verified hashes of the font files in the src/qml/res/fonts/ sub-directory:
$ sha256sum *
a7e791e8f5a0fb02b65663f7fca73e1d1ca9543f772ad480cbd76f4e3fe3f8cc Inter-Regular.otf
8c1990b6012254ea2b487161697d107357dd0ee55811cfd91c8c11227bbef457 Inter-SemiBold.otf
Hashes match ones I get for files from the Inter-3.19.zip archive which I've downloaded from https://rsms.me/inter/
Merged
promag
pushed a commit
to promag/gui-qml
that referenced
this pull request
Oct 29, 2021
0d624261ef Merge bitcoin-core/crc32c-subtree#2: Merge upstream cac7ca830b Merge commit 'fa5ade41ee480003d9c5af6f43567ba22e4e17e6' into bitcoin-fork fa5ade41ee Fix compilation warnings on ARM64 with old GCC versions. (bitcoin-core#52) db08d22129 Updated Travis-CI configuration. (bitcoin-core#51) e31619a5b7 Fix GitHub links. (bitcoin-core#50) 7fa4c263e8 Update Travis CI config. (bitcoin-core#49) a3d9e6d1a4 Updated third_party/ and Travis CI config. (bitcoin-core#48) git-subtree-dir: src/crc32c git-subtree-split: 0d624261ef83ab08c953c196540ed18f355add4c
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 12, 2024
d54ec27 qt: Add helper to load font (João Barbosa) Pull request description: Originally submitted as bitcoin-core/gui-qml#49. ACKs for top commit: hebasto: re-ACK d54ec27 stratospher: Tested ACK d54ec27. Refactoring the code and defining `loadFont()` in `src/qt/guiutil.cpp` reduces redundant imports of the `QFontDatabase` and is a better design. shaavan: ACK d54ec27 Tree-SHA512: b156bb6ffb08dd57476f383a29bbb0a1108b62794d430debb77252f7d09df1409a7532b09d17d8836d1c2ab7c126a6618231164b9d0def1b8f361a81ef22d107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @GBKS.