Skip to content

Fixed width for BlockCounter #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

katesalazar
Copy link
Contributor

Without this, BlockCounter is continuously changing width
unnecessarily. With a fixed width BlockCounter, visual output doesn't
change more than strictly necessary. At current window min size, this
width fits up to 9 digits, which is enough to fit all of main, test
and signature networks.

You can spot the difference these changes add by creating two dummy
data directories and bootstrapping one with this change and
bootstrapping the other one without this change.

Without this, BlockCounter is continuously changing width
unnecessarily. With a fixed width BlockCounter, visual output doesn't
change more than strictly necessary. At current window min size, this
width fits up to 9 digits, which is enough to fit all of main, test
and signature networks.

You can spot the difference these changes add by creating two dummy
data directories and bootstrapping one with this change and
bootstrapping the other one without this change.
@katesalazar
Copy link
Contributor Author

Blocks counter label is anchored to window height,
not to blocks counter height. Set draft.

@katesalazar katesalazar marked this pull request as draft October 3, 2021 13:35
Prevent BlockCounter label from spilling out of BlockCounter inner
"black" content.

This change was written on a laptop using a 1280x776 configuration (as
reported by `xrandr`).

To see this change in and out of action, it might be necessary not to
simply rebuild, but also explicitly removing src/qml/qrc_bitcoin.cpp
and/or src/qt/qrc_bitcoin.cpp.
@katesalazar katesalazar marked this pull request as ready for review October 3, 2021 13:56
Copy link
Contributor

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a dummy component just to show how to bind to the current block height. Not actually something that was designed and eventually it will be removed. I'd say there is no point in this change.

@hebasto
Copy link
Member

hebasto commented Oct 3, 2021

This is a dummy component just to show how to bind to the current block height. Not actually something that was designed and eventually it will be removed. I'd say there is no point in this change.

Yes. From #31 (comment):

adds a prototype of QML object which displays block tip height

@hebasto
Copy link
Member

hebasto commented Oct 3, 2021

@katesalazar

If you are interested in QML app, you could also look into https://github.com/BitcoinDesign/Bitcoin-Core-App

@hebasto
Copy link
Member

hebasto commented Oct 22, 2021

Going to close this for now.

@katesalazar

Hope to see more of your contributions into this repo :)

@hebasto hebasto closed this Oct 22, 2021
@katesalazar
Copy link
Contributor Author

Hope to see more of your contributions into this repo :)

I would love to, not much time to tinker around,
maybe in the future, who knows.

From what I've read these weeks
I think all of these are in good hands
and that's the point that matters to me.

jarolrod pushed a commit to jarolrod/gui-qml that referenced this pull request Oct 27, 2021
a44caf65fe Merge bitcoin-core/univalue-subtree#28: Import fixes for sanitizer reported issues
135254331e Import fixes for sanitizer reported issues
d5fb86940e refactor: use c++11 range based for loop in checkObject
ff9c379304 refactor: Use nullptr (c++11) instead of NULL
08a99754d5 build: use ax_cxx_compile_stdcxx.m4 to check for C++11 support
66d3713ce7 Merge bitcoin-core/univalue-subtree#29: ci: travis -> cirrus
808d487292 ci: travis -> cirrus
c390ac375f Merge bitcoin-core/univalue-subtree#19: Split sources for easier buildsystem integration
4a5b0a1c65 build: Move source entries out to sources.mk
6c7d94b33c build: cleanup wonky gen usage
a222637c6d Merge bitcoin-core#23: Merge changes from jgarzik/univalue@1ae6a23
f77d0f718d Merge commit '1ae6a231a0169938eb3972c1d48dd17cba5947e1' into HEAD
1ae6a231a0 Merge pull request bitcoin-core#57 from MarcoFalke/test_fix
92bdd11f0b univalue_write: remove unneeded sstream.h include
ffb621c130 Merge pull request bitcoin-core#56 from drodil/remove_sstream_header
f33acf9fe8 Merge commit '7890db9~' into HEAD
66e0adec4d Remove unnecessary sstream header from univalue.h
88967f6586 Version 1.0.4
1dc113dbef Merge pull request bitcoin-core#50 from luke-jr/pushKV_bool
72392fb227 [tests] test pushKV for boolean values
c23132bcf4 Pushing boolean value to univalue correctly
81faab26a1 Merge pull request bitcoin-core#48 from fwolfst/47-UPDATE_MIT_LINK_TO_HTTPS
b17634ef24 Update URLs to MIT license.
88ab64f6b5 Merge pull request bitcoin-core#46 from jasonbcox/master
35ed96da31 Merge pull request bitcoin-core#44 from MarcoFalke/Mf1709-univalue-cherrypick-explicit
420c226290 Merge pull request bitcoin-core#45 from MarcoFalke/Mf1710-univalue-revert-test

git-subtree-dir: src/univalue
git-subtree-split: a44caf65fe55b9dd8ddb08f04c0f70409efd53b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants