Add ChainModel #40
Closed
Add ChainModel #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
promag
force-pushed
the
2021-09-chainmodel
branch
from
ab19cae to
2d53bd2
Compare
promag
commented
Sep 28, 2021
|
|
||
| void ChainModel::fetchMore(const QModelIndex& parent) | ||
| { | ||
| auto& chain = Engine::chain(this); |
There was a problem hiding this comment.
Add qDebug() << Q_FUNC_INFO; while testing (scrolling the list) to see how lazy loading works.
There was a problem hiding this comment.
@ryanofsky using interfaces::Chain here.
promag
force-pushed
the
2021-09-chainmodel
branch
from
2d53bd2 to
3766f18
Compare
promag
commented
Sep 28, 2021
src/qml/pages/stub.qml
Outdated
|
|
||
| ListView { | ||
| anchors.fill: parent | ||
| model: ChainModel { |
There was a problem hiding this comment.
@ryanofsky this is a dumb example, but the idea is to access block details.
|
|
||
| void ChainModel::fetchMore(const QModelIndex& parent) | ||
| { | ||
| auto& chain = Engine::chain(this); |
There was a problem hiding this comment.
@ryanofsky using interfaces::Chain here.
Follow Qt recomendation (1) since the background is a solid color. 1. https://doc.qt.io/qt-5/qml-qtquick-controls2-applicationwindow.html#background-prop
Label implicit height depends on the font size but the font size depends on the label height. This results in a runtime anchor loop warning.
promag
force-pushed
the
2021-09-chainmodel
branch
from
3766f18 to
cb28239
Compare
|
Concept ACK, we're going to need to expose more than just the nodemodel to qml. One big backend object would be quite a mess. All that's needed is good documentation of what is exposed to qml and why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #38. This PR adds and uses the
ChainModel. This model exposes chain data, like block heights and hashes. Can be used as a source for list views and repeaters. The model uses a lazy load approach, ie, data is fetched frominterfaces::Chainas needed.