Reduce usage of ternaries in Theme file #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hebasto
reviewed
Aug 23, 2022
Reduces usage of ternaries in Theme.qml by abstracting definitions of colors and images into "Sets" and using the definitions from the appropriate set for the current dark mode setting. Co-authored-by: João Barbosa <joao.paulo.barbosa@gmail.com>
jarolrod
force-pushed
the
theme-avoid-ternaries
branch
from
9ff8924 to
6e0ee80
Compare
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Reduces usage of ternaries in Theme.qml by abstracting definitions of colors and images into "Sets" and using the definitions from the appropriate set for the current dark mode setting. Github-Pull: bitcoin-core#168 Rebased-From: 6e0ee80 Co-authored-by: João Barbosa <joao.paulo.barbosa@gmail.com>
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Reduces usage of ternaries in Theme.qml by abstracting definitions of colors and images into "Sets" and using the definitions from the appropriate set for the current dark mode setting. Github-Pull: bitcoin-core#168 Rebased-From: 6e0ee80 Co-authored-by: João Barbosa <joao.paulo.barbosa@gmail.com>
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Reduces usage of ternaries in Theme.qml by abstracting definitions of colors and images into "Sets" and using the definitions from the appropriate set for the current dark mode setting. Github-Pull: bitcoin-core#168 Rebased-From: 6e0ee80 Co-authored-by: João Barbosa <joao.paulo.barbosa@gmail.com>
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Reduces usage of ternaries in Theme.qml by abstracting definitions of colors and images into "Sets" and using the definitions from the appropriate set for the current dark mode setting. Github-Pull: bitcoin-core#168 Rebased-From: 6e0ee80 Co-authored-by: João Barbosa <joao.paulo.barbosa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces usage of ternaries in Theme.qml by abstracting definitions of colors and image urls into "Sets" and using the definitions from the appropriate set for the current dark mode setting.
This is a late follow-up to this review by promag: #109 (comment)