qml: Follow-up to PR#101 #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shaavan
commented
Jan 13, 2022
shaavan
commented
- This PR is a follow-up to Add and demo ConnectionSettings and ContinueButton components #101 and addresses suggestions of this comment.
- The changes are split into separate commits so that they can be easier to review, and reason with.
- Modified property last so that it can automatically be derived by root positioning in parent element. - Made header property to be necessarily required.
promag
reviewed
Jan 13, 2022
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 7, 2025
Github-Pull: bitcoin-core#112 Rebased-From: fe41329
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 7, 2025
Github-Pull: bitcoin-core#112 Rebased-From: be87ba9
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 7, 2025
Github-Pull: bitcoin-core#112 Rebased-From: a0ba0d7
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 7, 2025
- Modified property last so that it can automatically be derived by root positioning in parent element. - Made header property to be necessarily required. Github-Pull: bitcoin-core#112 Rebased-From: f5458f2
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Github-Pull: bitcoin-core#112 Rebased-From: fe41329
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Github-Pull: bitcoin-core#112 Rebased-From: be87ba9
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Github-Pull: bitcoin-core#112 Rebased-From: a0ba0d7
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
- Modified property last so that it can automatically be derived by root positioning in parent element. - Made header property to be necessarily required. Github-Pull: bitcoin-core#112 Rebased-From: f5458f2
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Github-Pull: bitcoin-core#112 Rebased-From: fe41329
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Github-Pull: bitcoin-core#112 Rebased-From: be87ba9
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Github-Pull: bitcoin-core#112 Rebased-From: a0ba0d7
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
- Modified property last so that it can automatically be derived by root positioning in parent element. - Made header property to be necessarily required. Github-Pull: bitcoin-core#112 Rebased-From: f5458f2
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#112 Rebased-From: fe41329
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#112 Rebased-From: be87ba9
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#112 Rebased-From: a0ba0d7
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
- Modified property last so that it can automatically be derived by root positioning in parent element. - Made header property to be necessarily required. Github-Pull: bitcoin-core#112 Rebased-From: f5458f2
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#112 Rebased-From: fe41329
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#112 Rebased-From: be87ba9
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#112 Rebased-From: a0ba0d7
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
- Modified property last so that it can automatically be derived by root positioning in parent element. - Made header property to be necessarily required. Github-Pull: bitcoin-core#112 Rebased-From: f5458f2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.