Support detail item inside option button #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Best reviewed without whitespace changes. |
Could there be an issue with RTL writing systems? |
I don't think so. Maybe we should raise that concern in the next meeting with designers. |
promag
force-pushed
the
2022-01-qml-optionbutton-detail
branch
from
1f5cd07 to
898d672
Compare
|
ni: misspelled word in 347f772 commit: s/suport/support |
promag
force-pushed
the
2022-01-qml-optionbutton-detail
branch
from
898d672 to
a55553c
Compare
|
@hebasto I am not sure what (if anything) is required for RTL writing systems for this type of component. I'll put it on my list and do a bit of research. |
hebasto
approved these changes
Jan 6, 2022
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 7, 2025
Github-Pull: bitcoin-core#103 Rebased-From: ab460a5
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 7, 2025
Github-Pull: bitcoin-core#103 Rebased-From: a55553c
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Github-Pull: bitcoin-core#103 Rebased-From: ab460a5
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Github-Pull: bitcoin-core#103 Rebased-From: a55553c
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Github-Pull: bitcoin-core#103 Rebased-From: ab460a5
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Github-Pull: bitcoin-core#103 Rebased-From: a55553c
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#103 Rebased-From: ab460a5
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#103 Rebased-From: a55553c
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#103 Rebased-From: ab460a5
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#103 Rebased-From: a55553c
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
fde8465 qml: Demo OptionButton detail in wifi-only option (João Barbosa) 5f3f324 qml: Support detail item inside OptionButton (João Barbosa) Pull request description: Allow a custom inlined item on the right-hand side of the `OptionButton`: https://user-images.githubusercontent.com/3534524/148144944-165f657a-e918-47ab-92f7-5641faf095f8.mov Links for Windows, macOS, and Android build artifacts. [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/103) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/103) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/103) ACKs for top commit: hebasto: ACK fde8465 Tree-SHA512: 58fbea8f5eed58e227ef65f46b03133ec847d329acd3ff2ebd066f5659411608e63b061eff216863125368faf04fa4a3baf01b46dfbbf9e8ed0e39840141e081
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a custom inlined item on the right-hand side of the
OptionButton:Screen.Recording.2022-01-05.at.01.08.34.mov
Links for Windows, macOS, and Android build artifacts.