changed verify_checksums_file string #894
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #878 |
|
Maybe: Verify that the checksums file is PGP signed by at least one trusted release signing key:? |
stickies-v
reviewed
Nov 30, 2022
There was a problem hiding this comment.
Concept ACK, suggested to rephrase that trust is personal
Also, please update the original PR description to state "Closes #891" so GitHub can track this better and automatically close the original issue upon merging.
|
Are you still working on this? |
Co-authored-by: stickies-v <69010457+stickies-v@users.noreply.github.com>
stickies-v
approved these changes
Jan 10, 2023
|
Sorry, it was by mistake |
|
cc @fanquake Can this be merged or does it need squash? (If yes, please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits) |
|
Thanks. I've cherry-picked & squashed your change, with an updated commit message, in #946. |
fanquake
added a commit
that referenced
this pull request
Jan 11, 2023
3c2a4e9 download: update verify_checksums_file string (Silas) Pull request description: Remove reference to "trusted release signing key". Squashed version of #894. ACKs for top commit: stickies-v: ACK 3c2a4e9 Tree-SHA512: 4c0b87333ce24ab67f48c46c11eb01854bb90878eb6b1e89239133463beee5a0523d3c13381089b6f3ba233e7e9943c18162089baad36bf22d6d5536f958a3fe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the clarity on the number of release signing keys based on Issue Closes #891