Drop Python 3.9, use 3.10 for dist, bump Ledger#819
Drop Python 3.9, use 3.10 for dist, bump Ledger#819Sjors wants to merge 11 commits intobitcoin-core:masterfrom
Conversation
8489c74 to
57f6690
Compare
57f6690 to
a608ea3
Compare
|
Rebased after #818 landed, ready for review. I lightly tested the dist builds on Ubuntu (x86_64, including qt) and macOS (only command line). I ran the GUI in Wine, but that doesn't have USB access so not very informative. I also ran it on a native Windows machine. Windows Defender wasn't happy about it, but I didn't do any code signing. There it detected a connected device, so that's good. I wonder if it makes sense for the deterministic binary releases to jump straight ahead to a more modern Python? Also, would it make sense to do one final HWI release with Python 3.9 before merging this? |
|
Added commit to re-enable the Ledger tests. |
a4e3a84 to
ae9e49d
Compare
|
Rebased just in case after recent merges. |
|
Does the dist build work on in an arm docker container, as described in the release process? |
This reduces churn when running this command again for the upcoming commits.
Also drops Python 3.6 dataclasses leftover.
ae9e49d to
f473a2e
Compare
I built inside an arm64 docker container on the x86 linux machine. I also made it do an Rebased again, this time using The first time I ran that command, it moved I also built and tested the x86 macOS build on a native machine. I was able to run the QT application and it connected to a test deviced and fetch the descriptors. Checksums: |
It's unused and occasionally trips up a test.
|
The spurious Ledger failure appears to be the result of the test suite occasionally hitting the Cancel / Reject button. Where Added a commit to drop that rule, since it's unused anyway. |
This PR first switches the deterministic builds to Python 3.10. It then drops the end-of-life 3.9.
Then it bumps Speculos and Ledger and enables the tests that were previously disabled.
There's also a few minor cleanup commits, plus changes to make the Docker containers Podman friendly so I can easily run them locally.