MISC: Add generic type as returned type for action and checking #1748
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: Originally, this PR moves Availability and Attempt to a more generic place. After discussing, we decide to create a new type instead of moving Availability and Attempt.
In the past, we sometimes used a returned string to indicate success/failure. For example:
purchaseAugmentation
(src\Faction\FactionHelpers.tsx
) returns a string. The caller will check if it starts with "You purchased" to see whether it succeeds.purchaseUnlock
andpurchaseUpgrade
return strings to indicate a failure.When refactoring those functions, I use
IReturnStatus
(src\types.ts
), then I seeAvailability
andAttempt
. I think these two types are pretty nice and can be used outside Bladeburner. This PR moves them tosrc\types.ts
.