IMPROVEMENT: partial migration @mui/styles to tss-react #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caldwell-74
changed the title
the nested structure of the styloes in IPvGO make it considerably harder to change away
|
sorry for the messy commits |
antoinedube
pushed a commit
to antoinedube/bitburner-source
that referenced
this pull request
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
its well known that @mui/styles is deprecated and stops us from updating other (core) packages like react
tss-react is a type safe package that implements a replacement for makeStyle that uses nearly the exact same syntax
its well maintained (>24k commits, closed >17k issues from ~19k, merged >22k PRs)
with a goal to stay seamlessly integrateable with mui
https://github.com/garronej/tss-react
i changed
allmost occurences of makeStyle, createStyle, withStyleone problem that occured was an import error thats why i moved the logBoxBaseZIndex into its own constant file to resolve it
another (not yet fixed) problem is that the IPvGo board is broken, here i hope to get help from Ficocelli the creator of IPvGo to resolve this aswellthe nested style structure of IPvGO makes it harder to migrate away from it thats why i reverted those changes
the package allows for nested structures but my understanding of the subject is not deep enough to migrate them correctly
so far i havent removed @mui/styles nor upgraded any packages