MISC: change all nextUpdates to use one Promise #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 20, 2024 02:41
|
i changed the sleeves bladeburner task to only create promises when needed instead of for each task by default |
|
Due to duplicate types being made, I just made a generic PromisePair type for storing a promise and its resolver. Rebase was just a conflict with corporation imports. |
|
i did think about that but wasnt comfy with generics in general but thanks and good job! |
Semanual
pushed a commit
to Semanual/bitburner-src
that referenced
this pull request
Feb 10, 2024
antoinedube
pushed a commit
to antoinedube/bitburner-source
that referenced
this pull request
Mar 17, 2024
G4mingJon4s
pushed a commit
to G4mingJon4s/bitburner-src
that referenced
this pull request
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partly a duplicate to #1068 but didnt want to fish that one change out of it since i had them all allready done