EDITOR: fix disposing models #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
extracted the model logic |
|
we could keep the models of openScripts around so we dont have to recreate them not sure how heavy that computational wise is |
|
Nice work! I will get this built on web/steam shortly |
G4mingJon4s
pushed a commit
to G4mingJon4s/bitburner-src
that referenced
this pull request
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the unmount of the editor didnt dispose the models correctly
could be that this was already the case before the URI changes and only got visible after
added a few more checks that if a model already exist that its loaded instead of creating a new one
and removed an imho annoying toTerminal call when closing and saving a script
it will still go to the terminal when its the last script that gets closed
the extra dispose and checks might be hard to verify that they work but i disabled the dispose on unmount and tested each of them alone