-
Notifications
You must be signed in to change notification settings - Fork 319
Add solo chance page #1368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add solo chance page #1368
Conversation
|
Screenshots are urgently needed! 😂 |
main/http_server/axe-os/src/app/components/home/home.component.ts
Outdated
Show resolved
Hide resolved
| // live data | ||
| this.info$ = interval(5000).pipe( | ||
| startWith(() => this.systemService.getInfo()), | ||
| startWith(0), // Emit immediately on subscription |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect usage found by AI
|
I would remove the description in the table and just leave the legend. |
I did not interfere at all with the text or code of the new page. I didn't even look at the code of the new page. I did check changes in existing code, and ran it on actual hardware. This PR is more of an experiment in how it handles the codebase, which didn't disappoint on almost every aspect. Also, I'm not an Angular expert, so I cannot really comment on code quality here, hence it's up for review. Content and text we can finetune later, when we deem the code is acceptable. I do like the P in the table as that's the future where we're going, the network diff will keep going up. It's a nice book-end of the table and whenever we cross that, we can add E. |
|
I don't want a P! 😤 That's a terrible thought. My poor Bitaxe will then only be worth remembering. |
c2401ad to
3245228
Compare
Fixes bitaxeorg#1362 This PR was mostly generated by Google's Antigravity AI. It's an experiment from my side. Things it did well: * Analysing the application * Finding a place to put new components * Discovering existing components (with some help) * Help with naming things * Verifying correct usage (see change in `home.components.ts``) Things it struggles with: * Styling, it didn't grasp the theme system, so all colors are hardcoded
3245228 to
2cc4fc3
Compare
Fixes #1362
This PR was mostly generated by Google's Antigravity IDE. It's an experiment from my side. Things it did well:
hashSuffixandtooltip-icon(only pointing out that they exist);home.components.ts)Things it struggles with:
Total development time: ~2 hours. This was almost exclusively front-end, where the integration shines. Not sure what it'll do with a back-end.