This repository was archived by the owner on Jan 23, 2024. It is now read-only.
fix(actions): import path of dsd AbstractActionsElemett
#341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the module path was incorrect in some actions leading to issues in setup of the DSD tree
Flova
approved these changes
Nov 28, 2023
Member
This is correct, the cleanup removed the import of these common elements in the init file resulting in a failure if they are imported at modul level. I actually liked the old way and would suggest to add it again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the module path was incorrect in some actions leading to issues in setup of the DSD tree
Summary
This is only an issue since the pre-commit cleanup, for some reason.
Checklist
colcon buildSoftwareproject board