This repository was archived by the owner on Jan 23, 2024. It is now read-only.
Adjust body behavior to head mover #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
val-ba
force-pushed
the
feature/move_head_behavior_to_cpp
branch
from
f9fd8dd to
f059b9f
Compare
val-ba
force-pushed
the
feature/adjust_body_behavior_to_head_mover
branch
from
20b0356 to
5d4f641
Compare
Member
|
How where you able to merge without a review. Also the other PR is still open. |
Member
|
I believe, since this did not merge into the protected master, its okay |
Member
|
I didn't notice the target branch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Interface of head behavior changed due to #295
Related issues
Necessary checks
The behavior does not crash, but has weird behavior sometimes. But it seems similar to the one the robot is doing when on the master branch.
catkin build