Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ControlPortFileParser: Handle "\r\n" newline encoding #2047

Merged
merged 1 commit into from
Apr 14, 2024
Merged

ControlPortFileParser: Handle "\r\n" newline encoding #2047

merged 1 commit into from
Apr 14, 2024

Conversation

alvasw
Copy link
Contributor

@alvasw alvasw commented Apr 14, 2024

Lines end with "\r\n" on Windows.

@alvasw alvasw added bug Something isn't working tor labels Apr 14, 2024
djing-chan
djing-chan approved these changes Apr 14, 2024
View reviewed changes
Copy link
Contributor

@djing-chan djing-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@djing-chan djing-chan merged commit 1dcdc74 into bisq-network:main Apr 14, 2024
16 checks passed
@djing-chan djing-chan added this to the 2.0.3 milestone Apr 17, 2024
@alvasw alvasw mentioned this pull request Apr 26, 2024
Open
@alvasw alvasw deleted the control_port_parser_handle_windows_newline branch May 21, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djing-chan djing-chan djing-chan approved these changes

Assignees
No one assigned
Labels
bug Something isn't working tor
Projects
None yet
Milestone
2.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@alvasw @djing-chan