Remove null check for unLockupTxId

[HenrikJannsen]

Fixes #replaceWithIssueNr, fixes #replaceWithIssueNr

Your PR description here.

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of bonded reputation records to properly process LOCKUP transactions that may have associated unlock transactions, removing an overly restrictive validation constraint.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The toBondedReputationDto method in BsqBlockGrpcService has been modified to remove the strict null enforcement on unlockTxId for LOCKUP transactions. The method now permits unlockTxId to be either present or absent, requiring only that lockupTxId is non-null and matches the transaction ID.

Changes

Cohort / File(s)	Summary
LOCKUP transaction nullability relaxation bridge/src/main/java/bisq/bridge/grpc/services/BsqBlockGrpcService.java	Removed checkArgument that enforced unlockTxId to be null in the LOCKUP transaction path of toBondedReputationDto; now permits unlockTxId to exist for LOCKUP entries

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Single file modification affecting one method
• Single assertion removal with minimal logic change
• No new control flow or complex interactions introduced

Possibly related PRs

• bisq#7550: Modifies BsqBlockGrpcService's lockup/unlock transaction ID handling and nullability checks in related code paths.
• bisq#7548: Directly related change to the same method; handles complementary modifications to unlockTxId and isUnlocked in BondedReputationDto.

Poem

🐰 A lock without a key to bind,
Now floats free in the unlock-less mind—
One assertion falls away so light,
And constraints relax into the night. ✨

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f771e65 and 49e96cb.

📒 Files selected for processing (1)

• bridge/src/main/java/bisq/bridge/grpc/services/BsqBlockGrpcService.java (0 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}