Fix: incorrect wallet tx handling #6422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue with the transaction having a non-initialized updateTime and/or blockTime because the wallet transaction was not returned.
|
@jmacxx Maybe rename the title to make it more clear that its about incorrect wallet tx handling |
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: altcoins/sepa instant BTC buyer's trade timer started too early
This is problematic in mainnet scenarios when a block is not published for 1 hour. The user is prompted to start payment after the first confirm, and they are also prompted that the trade has expired and to open mediation.
Issue description / steps to reproduce:
There was an issue with the transaction having a non-initialized blockTime because on the buyer's side the transaction was not obtained from the wallet, instead the serialized transaction was used which does not have a timestamp.