Refactor dispute validation #6402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
…the dispute domain. Move AddressException, NodeAddressException and DisputeReplayException to DisputeValidation. Use DisputeValidation.ValidationException as type for DisputeManager.validationExceptions. Remove Nullable annotation for dispute field in those exceptions. Remove null checks when those DisputeValidation.ValidationException are used.
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
…tion Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
…n out of TradeDataValidation Refactor donationAddress validation out to new method Rename addressAsString to delayedPayoutTxOutputAddressAsString Recreate delayedPayoutTxOutputAddress at new validateDonationAddress method from relevant data Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Add call to validateDonationAddress at client calling validateDelayedPayoutTx Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Remove dispute as unused param Remove redundant methods Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
…got added to support not updated nodes. Now there are none of such nodes. Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Remove null check for dispute Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
|
Awesome work, congrats on your first merged pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical refactoring of validation code.
This is a preparation for the implementation of bisq-network/proposals#390 and another intermediary PR with additional validations and further refactorings.