Store the build's commit hash in Jarfile manifest #6396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 29, 2022 22:12
logging of: `The requester had version x.x.x. Our historical data store has version y.y.y As the requester version is not older as our historical store we do not add the data to the result map.` Which takes up many screenfuls of log for every client getDataRequest.
HenrikJannsen
approved these changes
Nov 24, 2022
| @@ -135,6 +139,16 @@ public static void printVersion() { | |||
| '}'); | |||
| } | |||
|
|
|||
| public String readCommitHash() { | |||
There was a problem hiding this comment.
Maybe better to use a static method.
| @@ -151,7 +150,7 @@ public void onMessage(NetworkEnvelope networkEnvelope, Connection connection) { | |||
|
|
|||
| // node | |||
| inventory.put(InventoryItem.version, Version.VERSION); | |||
| inventory.put(InventoryItem.commitHash, RequestInfo.COMMIT_HASH); | |||
| inventory.put(InventoryItem.commitHash, new Version().readCommitHash()); | |||
There was a problem hiding this comment.
A static method would be more natural here.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The seednode monitor displays a misleading commit hash, just a hardcoded string which never changes.
This PR fixes that by obtaining the git HEAD commit hash at build time, storing it in the Jarfile manifest information.
Seednodes then report the correct commit hash so that the monitor will indicate what commit they are running.
This is useful to know what source the seednode was built from.
e.g: