Deprecate and replace hard-coded CLI console output formatters #5812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If not present, a default BSQ swap account is saved when a User object is initialized. Use the existing default account in API bsq-swap test cases, and rename the legacy BSQ payment account fixtures to distinguish them from the new default 'BSQ Swap' payment account.
The user's default bsq-swap account is used instead.
A minor refactoring of some deprecated classes is included.
ripcurlx
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new CLI console output formatting api, which dynamically formats and justifies console output via a table of columns, populated from protobuf messages. New test cases are included to verify there are no differences between the old console output "api" and the new one.
Some refactoring of apitest trading test cases was done to reduce class size.
Based on PR #5811