-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BSQ swaps: Refactorings (non funtional changes) [1] #5769
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghubstan
reviewed
Oct 20, 2021
The build fails because |
|
chimp1984
changed the title
Refactorings (non funtional changes)
Refactorings (non funtional changes) [1]
Oct 21, 2021
No idea why the gradle dependencyVerification fails. It is the same content as in the release branch. |
chimp1984
changed the title
Refactorings (non funtional changes) [1]
BSQ swaps: Refactorings (non funtional changes) [1]
Oct 21, 2021
…core.offer.placeoffer.bisq_v1
BuyerAsMakerTrade, BuyerAsTakerTrade, BuyerTrade to bisq.core.trade.model.bisq_v1 package
Move TradeMessage into bisq.core.trade.protocol package
…ore.trade.bisq_v1
…radeUtil, TradeTxException to package bisq.core.trade.bisq_v1
chimp1984
force-pushed
the
chimp-bsq-swap
branch
from
November 2, 2021 14:40
4c1cb81
to
1f6d0ac
Compare
chimp1984
force-pushed
the
chimp-bsq-swap
branch
from
November 2, 2021 14:42
1f6d0ac
to
56759be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://github.com/bisq-network/bisq/tree/release/v1.7.5
This contains only renaming, moving and increasing visibility (package scope to public) as preparation for the further BSQ swap PRs.
EDIT: Merged with master and rebased.