Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tether (ERC20) #5735

Merged
merged 2 commits into from Oct 4, 2021
Merged

Add Tether (ERC20) #5735

merged 2 commits into from Oct 4, 2021

Conversation

ghost
Copy link

@ghost ghost commented Sep 29, 2021

Altcoin Tether (ERC20) added using code originally submitted in #4457 and #4434

As requested here bisq-network/proposals#170 (comment)
and here bisq-network/projects#60 (comment)

As discussed on the dev call with @leo816, Tether will have no price feed (same as other stablecoins on Bisq). Makers will need to enter the fixed offer price.


offerbook_USDT

@boring-cyborg boring-cyborg bot added in:altcoins is:no-priority PR or issue marked with this label is not up for compensation right now labels Sep 29, 2021
@ripcurlx
Copy link
Contributor

@jmacxx This PR is missing the required test for the token. I think this check wasn't ported to the GitHub build system when we had to switch build systems.

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK - Please see #5735 (comment)

@ghost ghost requested a review from ripcurlx October 2, 2021 23:54
@ripcurlx ripcurlx added this to the v1.7.5 milestone Oct 4, 2021
@ripcurlx ripcurlx merged commit 1c01180 into bisq-network:master Oct 4, 2021
@ghost ghost deleted the add-USDT-E branch October 5, 2021 14:14
@ghost ghost mentioned this pull request Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:altcoins is:no-priority PR or issue marked with this label is not up for compensation right now
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant