Simplify witness signing #4455
Merged
Simplify witness signing #4455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps dev work to have a separate signing area without need for legacy arbitrator registration. Legacy arbitrator key is still needed to sign accounts. Account information is also needed.
|
@ripcurlx not sure what codacy is on about with this PR, looks odd. |
|
@sqrrm I just looked at the Codacy complaints in AccountView and SigningView and they are legit IMO. |
|
Yeah, the complaints were correct, although I don't like the forced use of equals(). Still good that codacy is actually doing some good work. |
ripcurlx
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps developers sign accounts as needed.
For mainnet this helps legacy arbitrator to sign without having to register as a legacy arbitrator, just add the private key when doing the signing.