Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update social links #395

Merged
merged 7 commits into from
Sep 11, 2020
Merged

Update social links #395

merged 7 commits into from
Sep 11, 2020

Conversation

m52go
Copy link
Contributor

@m52go m52go commented Sep 3, 2020

This PR:

  • adds region-specific links to Telegram groups, since these groups are active and monitored by active contributors
  • specifies the "correct" Matrix group (the active one that's connected to IRC) to address List Matrix channel on Community page #346
  • removes the bisq-contrib email list link since most users won't want to use it anyway

This PR assumes #394 will be merged so it doesn't change links on any community pages.

m52go added 6 commits September 2, 2020 16:08
It's currently the only social channel that differs among languages.
It's not really something we want most users signing up for.
So new region-specific social channels can be added easily.
Changed it to "join community" since that seemed more appropriate.
Did it for all languages since it's a string we already had.
@Bayernatoor
Copy link
Member

Hmmm, unless I messed up. I do not see the changes when running your PR locally. No telegram or matrix links and the mailing list link is still there. Got a netlify link?

@m52go
Copy link
Contributor Author

m52go commented Sep 8, 2020

Got a netlify link?

Yup, try https://deploy-preview-395--bisq-website.netlify.app/.

@Bayernatoor
Copy link
Member

Looks good to me! ACK

@m52go m52go merged commit d537782 into bisq-network:master Sep 11, 2020
@m52go m52go deleted the update-social-links branch September 11, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants