Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial biscuit implementation #5

Merged
merged 26 commits into from
Aug 19, 2020
Merged

Initial biscuit implementation #5

merged 26 commits into from
Aug 19, 2020

Conversation

daeMOn63
Copy link
Contributor

@daeMOn63 daeMOn63 commented Aug 11, 2020

Brings bases for biscuit creation and validation

Copy link
Contributor

@titanous titanous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great start!

biscuit.go Outdated Show resolved Hide resolved
builder.go Outdated Show resolved Hide resolved
@titanous titanous marked this pull request as draft August 11, 2020 16:55
biscuit.go Outdated Show resolved Hide resolved
@daeMOn63 daeMOn63 marked this pull request as ready for review August 17, 2020 15:25
@daeMOn63 daeMOn63 requested a review from titanous August 17, 2020 15:26
@daeMOn63 daeMOn63 changed the title wip Initial biscuit implementation Aug 17, 2020
biscuit.go Outdated Show resolved Hide resolved
biscuit.go Outdated Show resolved Hide resolved
builder.go Outdated Show resolved Hide resolved
builder.go Outdated Show resolved Hide resolved
builder.go Outdated Show resolved Hide resolved
sig/crypto.go Outdated Show resolved Hide resolved
sig/crypto.go Outdated Show resolved Hide resolved
sig/crypto.go Outdated Show resolved Hide resolved
types.go Outdated Show resolved Hide resolved
types.go Outdated Show resolved Hide resolved
biscuit.go Outdated Show resolved Hide resolved
biscuit.go Outdated Show resolved Hide resolved
builder.go Outdated Show resolved Hide resolved
builder.go Outdated Show resolved Hide resolved
builder.go Outdated Show resolved Hide resolved
builder.go Outdated Show resolved Hide resolved
builder.go Outdated Show resolved Hide resolved
Copy link
Contributor

@titanous titanous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Squash it!

authority symbol must be prepended, instead of replacing the existing
symbol
@daeMOn63 daeMOn63 merged commit a0282d7 into master Aug 19, 2020
@daeMOn63 daeMOn63 deleted the biscuit_impl branch August 19, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants