-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recompute OWSRegistry on demand to avoid caching issues with db-session #111
Conversation
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
=======================================
Coverage 72.16% 72.16%
=======================================
Files 40 40
Lines 1703 1703
=======================================
Hits 1229 1229
Misses 474 474
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@fmigneault feel free to merge. |
@cehbrecht |
@fmigneault I have uploaded the packages now. I have invited you as maintainer on pypi. |
@cehbrecht |
So far, I have done the upload always manually. @Zeitsperre do you have experience with this? Would you recommend to have it in the CI? |
@cehbrecht |
@fmigneault yes ... using @Zeitsperre do you have experience with release automation in CI? I think I have seen something in a ci config ... but it was not used. |
Description
This resolves many long standing issues related to request caching negotiation between Magpie and Twitcher.
As illustrated in this test results, many requests are failing due to
NoTransaction
error:bird-house/birdhouse-deploy#197 (comment)
Following this fix (manually integrated in Ouranosinc/Magpie@
ae1698a
(#488) and corresponding Magpie & Twitcher Dockers pushed with manual tags), following results are obtained.ignore
weaver
errors that are unrelated, all else are gone including notablystress-tests
http://daccs-jenkins.crim.ca/job/DACCS-iac-birdhouse/789
http://daccs-jenkins.crim.ca/job/PAVICS-e2e-workflow-tests/job/master/672
After this PR is integrated, I will properly tag/bump Twitcher with
0.6.2
and apply it to Magpie for3.19.0
release.References